[Uml-devel] Forward: deeper freeze

[Sebastian Stein]

Jonathan Riddell <jr at jriddell.org> [031111 16:05]:
> 67222 Umbrello crashes while removing operations from classes
>  - I havn't investigated this, presumably needs some investigation to
> see if there is a problem and how to solve it

I can't reproduce this one.
 
> 67765 crash when deleting last parameter of an operation

I have a patch for this one:

===================================================================
RCS file: /home/kde/kdesdk/umbrello/umbrello/operation.cpp,v
retrieving revision 1.13
diff -u -r1.13 operation.cpp
--- operation.cpp	15 Oct 2003 20:23:10 -0000	1.13
+++ operation.cpp	11 Nov 2003 16:23:12 -0000
@@ -50,11 +50,11 @@
 }
 ////////////////////////////////////////////////////////////////////////////////////////////////////
 void UMLOperation::removeParm(UMLAttribute * a) {
+	disconnect(a,SIGNAL(modified()),this,SIGNAL(modified()));
 	if(!m_List.remove(a))
 		kdDebug() << "Error removing parm" << endl;
 
 	emit modified();
-	disconnect(a,SIGNAL(modified()),this,SIGNAL(modified()));
 }
 ////////////////////////////////////////////////////////////////////////////////////////////////////
 UMLAttribute* UMLOperation::findParm(QString name) {


We have to first disconnect and than delete the object. That's all! Should I
commit it?
 
> 65502 C++ code generator is broken, maybe other as well
>  - I think this can be closed now?

Let it open some more days. There are still some problems to be solved
(maybe only in Java), but we can use this bug for being allowed to submit a
patch ;-)

Steinchen
-- 
Umbrello UML Modeller
Description     : UML diagram drawing tool for KDE with code generation
Homepage        : http://www.umbrello.org/
Bug Reports     : http://bugs.kde.org/
CVS             : kdesdk/umbrello on cvs.kde.org:/home/kde