[Uml-devel] Forward: deeper freeze

Jonathan Riddell jr at jriddell.org
Tue Nov 11 08:32:16 UTC 2003


On Tue, Nov 11, 2003 at 05:25:51PM +0100, Sebastian Stein wrote:
> > 67765 crash when deleting last parameter of an operation
> 
> I have a patch for this one:
> 
> ===================================================================
> RCS file: /home/kde/kdesdk/umbrello/umbrello/operation.cpp,v
> retrieving revision 1.13
> diff -u -r1.13 operation.cpp
> --- operation.cpp	15 Oct 2003 20:23:10 -0000	1.13
> +++ operation.cpp	11 Nov 2003 16:23:12 -0000
> @@ -50,11 +50,11 @@
>  }
>  ////////////////////////////////////////////////////////////////////////////////////////////////////
>  void UMLOperation::removeParm(UMLAttribute * a) {
> +	disconnect(a,SIGNAL(modified()),this,SIGNAL(modified()));
>  	if(!m_List.remove(a))
>  		kdDebug() << "Error removing parm" << endl;
>  
>  	emit modified();
> -	disconnect(a,SIGNAL(modified()),this,SIGNAL(modified()));
>  }
>  ////////////////////////////////////////////////////////////////////////////////////////////////////
>  UMLAttribute* UMLOperation::findParm(QString name) {

Looks good to me, go ahead.

Jonathan




More information about the umbrello-devel mailing list