[Uml-devel] Hi guys - I'm back!!

[Peeter Russak]

Ok, previous mail didn't get through. You can find 
patch from http://pezz.tkwcy.ee/uml/indent_gpl.patch.bz2

-- 
Peeter


---------- Forwarded message ----------
Date: Wed, 15 May 2002 00:36:37 +0300 (EEST)
From: Peeter Russak <pezz at foma.tkwcy.ee>
To: umbrello-devel at kde.org
Subject: Re: [Uml-devel] Hi guys - I'm back!!

On Tue, 14 May 2002, Gustavo Madrigal wrote:

> I think it would be useful to differenciate parameter variables 
> from function local variables, for this I propose to start parameter names in 
> capital (i.e. Parameter instead of parameter) and start local variables in 
> small caps. 

Please don't. First word starting with small letter and all other words 
with big letter (e.g. veryGoodCounter) would be good enough rule for all 
non-member variables. There's no need to differ parameters and local
variables because functions bigger than 20-40 lines should be considered 
overbloated anyway;) 

> Another thing I don't like about the code is the use of regular 
> C-style casts, I think is better to switch to C++-style casts (static_cast, 
> dynamic_cast, etc).

I've seen that from time to time there's been problems with one of 
them (I can't remember which one) because gcc doesn't handle it 
correctly.

> I think we should have something like coding_style.txt in CVS.

/me thinks all these rules are so common that there _must_ be already
several written documents about it that can be used. I'll check if I
can find one.

> To modify the actual code is it possible to use a C++ code beautifier? If so 
> which one?

Attached huge patch
* indents all .cpp and .h files using
astyle --indent=tab=8 --indent-cases --brackets=linux --pad=all $i
* adds GPL license standard header to files that had no license notice
* fixes some compiler warnings

-- 
Peeter