Review Request 125544: Fix limit/offset handling when sort option is no sort.
Xuetian Weng
wengxt at gmail.com
Fri Oct 9 17:54:55 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125544/
-----------------------------------------------------------
(Updated Oct. 9, 2015, 5:54 p.m.)
Review request for Baloo, Release Team and Vishesh Handa.
Repository: baloo
Description (updated)
-------
The bug is obvious, old code uses limit instead of (limit > 0), which gracefully handles limit < 0 case (means everything).
After offset is introduced, limit < 0 case is not handled properly.
This patch contains following changes:
1. make offset uint, m_offset is uint in Query already.
2. handle limit < 0 case properly.
Also fix offset with sorting.
Diffs
-----
src/lib/searchstore.h 17b4263
src/lib/searchstore.cpp a2e7749
Diff: https://git.reviewboard.kde.org/r/125544/diff/
Testing (updated)
-------
baloosearch:/ doesn't return anything because of this, now it properly returns result.
Play with baloosearch command a little bit, offset and limit returns the [offset, offset + limit) and no crash on the border case.
Thanks,
Xuetian Weng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20151009/fc11a645/attachment.html>
More information about the release-team
mailing list