Review Request 125544: Fix limit/offset handling when sort option is no sort.

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125544/
-----------------------------------------------------------

(Updated Oct. 9, 2015, 5:47 p.m.)


Review request for Baloo, Release Team and Vishesh Handa.


Changes
-------

1. Always sort whole resultIds, then pick [offset, offset + limit) from it.
2. Consider offset when no sort is required.


Repository: baloo


Description
-------

The bug is obvious, old code uses limit instead of (limit > 0), which gracefully handles limit < 0 case (means everything).

After offset is introduced, limit < 0 case is not handled properly.

This patch contains following changes:
1. make offset uint, m_offset is uint in Query already.
2. handle limit < 0 case properly.


Diffs (updated)
-----

  src/lib/searchstore.h 17b4263 
  src/lib/searchstore.cpp a2e7749 

Diff: https://git.reviewboard.kde.org/r/125544/diff/


Testing
-------

baloosearch:/ doesn't return anything because of this, now it properly returns result.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20151009/caf68bc0/attachment.html>