kde-runtime patches for cmake 2.8.9

[Aleix Pol]

On Mon, May 12, 2014 at 8:09 AM, Andreas Schneider <asn at cryptomilk.org>wrote:

> On Monday 12 May 2014 00:29:23 Albert Astals Cid wrote:
> > Hi guys, can you all confirm that
> > 0f9b161c3d244219a8df7e5263b1d89e9750c657
> > and
> > b4165b12e3a72057cd770cb53448b1f251aa8e65
> >
> > Still work/do what they should do and on top of that works in cmake
> 2.8.9?
> >
> > If so i'll repackkage the tarballs for 4.13.1
> >
> > Cheers,
> >   Albert
> >
> >
> http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=b4165b12e3a72057cd770c
> > b53448b1f251aa8e65
> >
> http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=0f9b161c3d244219a8df7
> > e5263b1d89e9750c657
>
> No, cause in kioslave/CMakelists.txt we have
>
> if (LIBSSH_FOUND)
>   add_subdirectory(sftp)
> endif (LIBSSH_FOUND)
>
>
> See
> http://quickgit.kde.org/?p=kde-runtime.git&a=blob&h=b150290c4eff34d9f997cad1c934457747e28ff5&hb=952de1ce1493713f6e798a80d20e9dec89a07688&f=kioslave%2FCMakeLists.txt#l47
>
>
> So libssh is never built, even if cmake finds it ...
>
>
> Please fix it, thanks!
>
>
> Cheers,
>
>         -- andreas
>
> _______________________________________________
> release-team mailing list
> release-team at kde.org
> https://mail.kde.org/mailman/listinfo/release-team
>


It's actually not because of any specification of the cmake documentation
or any black magic. In FindLibSSH.cmake:74 it's specifically
defining LIBSSH_FOUND not LibSSH_FOUND.

The variable is defined automatically for *Config.cmake files.

The current code seems correct and works here. +1

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20140513/f44cc325/attachment.html>