kde-runtime patches for cmake 2.8.9

[Albert Astals Cid]

El Dilluns, 12 de maig de 2014, a les 09:34:27, Christophe Giboudeaux va 
escriure:
> Hi,
> 
> On Monday 12 May 2014 08:09:59 Andreas Schneider wrote:
> > On Monday 12 May 2014 00:29:23 Albert Astals Cid wrote:
> > > Hi guys, can you all confirm that
> > > 0f9b161c3d244219a8df7e5263b1d89e9750c657
> > > and
> > > b4165b12e3a72057cd770cb53448b1f251aa8e65
> > > 
> > > Still work/do what they should do and on top of that works in cmake
> > > 2.8.9?
> > > 
> > > If so i'll repackkage the tarballs for 4.13.1
> > > 
> > > Cheers,
> > > 
> > >   Albert
> > > 
> > > http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=b4165b12e3a72057cd
> > > 77
> > > 0c b53448b1f251aa8e65
> > > http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=0f9b161c3d244219a8
> > > df
> > > 7
> > > e5263b1d89e9750c657
> > 
> > No, cause in kioslave/CMakelists.txt we have
> > 
> > if (LIBSSH_FOUND)
> > 
> >   add_subdirectory(sftp)
> > 
> > endif (LIBSSH_FOUND)
> > 
> > 
> > 
> > See
> > http://quickgit.kde.org/?p=kde-runtime.git&a=blob&h=b150290c4eff34d9f997ca
> > d
> > 1c934457747e28ff5&hb=952de1ce1493713f6e798a80d20e9dec89a07688&f=kioslave%2
> > FC MakeLists.txt#l47
> > 
> > 
> > So libssh is never built, even if cmake finds it ...
> 
> You mean sftp ? You didn't really test, right ?
> 
> From
> http://www.cmake.org/cmake/help/v2.8.9/cmake.html#module:FindPackageHandleSt
> andardArgs « if <var1> through <varN> are all valid, <UPPERCASED_NAME>_FOUND
> will be set to TRUE »
> 
> (the default behaviour didn't change in CMake 2.8.12)

I have tried this too and the variables are correctly set in the uppercase 
version so i'll update the tarballs with these changes.

Cheers,
  Albert

> 
> > Please fix it, thanks!
> 
> Why not, but what needs fixing? :)
> 
> 
> Christophe.