<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, May 12, 2014 at 8:09 AM, Andreas Schneider <span dir="ltr"><<a href="mailto:asn@cryptomilk.org" target="_blank">asn@cryptomilk.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">On Monday 12 May 2014 00:29:23 Albert Astals Cid wrote:<br>


> Hi guys, can you all confirm that<br>
> 0f9b161c3d244219a8df7e5263b1d89e9750c657<br>
> and<br>
> b4165b12e3a72057cd770cb53448b1f251aa8e65<br>
><br>
> Still work/do what they should do and on top of that works in cmake 2.8.9?<br>
><br>
> If so i'll repackkage the tarballs for 4.13.1<br>
><br>
> Cheers,<br>
>   Albert<br>
><br>
> <a href="http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=b4165b12e3a72057cd770c" target="_blank">http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=b4165b12e3a72057cd770c</a><br>
> b53448b1f251aa8e65<br>
> <a href="http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=0f9b161c3d244219a8df7" target="_blank">http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=0f9b161c3d244219a8df7</a><br>
> e5263b1d89e9750c657<br>
<br>
</div>No, cause in kioslave/CMakelists.txt we have<br>
<br>
if (LIBSSH_FOUND)<br>
  add_subdirectory(sftp)<br>
endif (LIBSSH_FOUND)<br>
<br>
<br>
See <a href="http://quickgit.kde.org/?p=kde-runtime.git&a=blob&h=b150290c4eff34d9f997cad1c934457747e28ff5&hb=952de1ce1493713f6e798a80d20e9dec89a07688&f=kioslave%2FCMakeLists.txt#l47" target="_blank">http://quickgit.kde.org/?p=kde-runtime.git&a=blob&h=b150290c4eff34d9f997cad1c934457747e28ff5&hb=952de1ce1493713f6e798a80d20e9dec89a07688&f=kioslave%2FCMakeLists.txt#l47</a><br>


<br>
<br>
So libssh is never built, even if cmake finds it ...<br>
<br>
<br>
Please fix it, thanks!<br>
<br>
<br>
Cheers,<br>
<br>
        -- andreas<br>
<div class=""><div class="h5"><br>
_______________________________________________<br>
release-team mailing list<br>
<a href="mailto:release-team@kde.org">release-team@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/release-team" target="_blank">https://mail.kde.org/mailman/listinfo/release-team</a><br>
</div></div></blockquote></div><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">It's actually not because of any specification of the cmake documentation or any black magic. In FindLibSSH.cmake:74 it's specifically defining LIBSSH_FOUND not LibSSH_FOUND.</div>

<div class="gmail_extra"><br></div><div class="gmail_extra">The variable is defined automatically for *Config.cmake files.</div><div class="gmail_extra"><br></div><div class="gmail_extra">The current code seems correct and works here. +1</div>

<div class="gmail_extra"><br></div><div class="gmail_extra">Aleix</div></div>