[rekonq] Review Request: Make the error page a bit prettier
Anton Kreuzkamp
akreuzkamp at web.de
Sat Jun 2 20:40:09 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105124/
-----------------------------------------------------------
(Updated June 2, 2012, 8:40 p.m.)
Review request for rekonq and Andrea Diamantini.
Changes
-------
I added a screenshot with the same image on a grey background. (I'll update the patch, if you like it)
It somehow reminds me of thunderclouds. This dark, depressive-looking grey with the schemes in it. It has something very emotional. I like it. Not sure whether this fits here, though.
Alternatively we could stick with the totally grey background. It looks least fancy, but most functional and probably most like "error".
PS: I'd like to know whether you prefer the bright, or the Plasma-like boxes, as I think it's better to have only one kind of boxes for the newtab- and error-pages.
Description
-------
Add a background-image, a box-shadow and a warning-symbol to indicate it's a error-page. See screenshot.
I've created an alternative version, with a more Plasma-like box, I've posted it in a similar review-request for the new tab page (https://git.reviewboard.kde.org/r/105123/).
Diffs
-----
src/data/rekonqinfo.html 35fade4
src/webpage.cpp bc4d0aa
Diff: http://git.reviewboard.kde.org/r/105124/diff/
Testing
-------
Screenshots (updated)
-----------
The error page with this patch
http://git.reviewboard.kde.org/r/105124/s/586/
A grey alternative (not in this patch))
http://git.reviewboard.kde.org/r/105124/s/588/
Thanks,
Anton Kreuzkamp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120602/703046a0/attachment.html>
More information about the rekonq
mailing list