[rekonq] Review Request: Make the error page a bit prettier
Andrea Diamantini
adjam7 at gmail.com
Sat Jun 2 06:20:17 UTC 2012
> On June 2, 2012, 6:18 a.m., Andrea Diamantini wrote:
> > Very nice, but for the warning icon. Can you please remove it? We probably just exaggerated with them...
> > Last thing: did you know the same html page is used for file/ftp pages? Did you check also loading your home page there?
No, last thing is this ;)
I think we need a "more dark" background for such a page, but couldn't find none kde related. What do you think? Can you suggest something?
- Andrea
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105124/#review14354
-----------------------------------------------------------
On May 31, 2012, 9:50 p.m., Anton Kreuzkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105124/
> -----------------------------------------------------------
>
> (Updated May 31, 2012, 9:50 p.m.)
>
>
> Review request for rekonq and Andrea Diamantini.
>
>
> Description
> -------
>
> Add a background-image, a box-shadow and a warning-symbol to indicate it's a error-page. See screenshot.
>
> I've created an alternative version, with a more Plasma-like box, I've posted it in a similar review-request for the new tab page (https://git.reviewboard.kde.org/r/105123/).
>
>
> Diffs
> -----
>
> src/data/rekonqinfo.html 35fade4
> src/webpage.cpp bc4d0aa
>
> Diff: http://git.reviewboard.kde.org/r/105124/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> The error page with this patch
> http://git.reviewboard.kde.org/r/105124/s/586/
>
>
> Thanks,
>
> Anton Kreuzkamp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120602/d72ec40b/attachment.html>
More information about the rekonq
mailing list