[rekonq] Review Request: Make the error page a bit prettier
Andrea Diamantini
adjam7 at gmail.com
Tue Jun 5 10:10:48 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105124/#review14418
-----------------------------------------------------------
I like the "grey" background in the second screenshot, but it seems to me that the central box is a bit too much... "transparent". It probably should be more "blank", more bright. What do you think?
- Andrea Diamantini
On June 2, 2012, 8:40 p.m., Anton Kreuzkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105124/
> -----------------------------------------------------------
>
> (Updated June 2, 2012, 8:40 p.m.)
>
>
> Review request for rekonq and Andrea Diamantini.
>
>
> Description
> -------
>
> Add a background-image, a box-shadow and a warning-symbol to indicate it's a error-page. See screenshot.
>
> I've created an alternative version, with a more Plasma-like box, I've posted it in a similar review-request for the new tab page (https://git.reviewboard.kde.org/r/105123/).
>
>
> Diffs
> -----
>
> src/data/rekonqinfo.html 35fade4
> src/webpage.cpp bc4d0aa
>
> Diff: http://git.reviewboard.kde.org/r/105124/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> The error page with this patch
> http://git.reviewboard.kde.org/r/105124/s/586/
> A grey alternative (not in this patch))
> http://git.reviewboard.kde.org/r/105124/s/588/
>
>
> Thanks,
>
> Anton Kreuzkamp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120605/93fe863e/attachment-0001.html>
More information about the rekonq
mailing list