[rekonq] Review Request: Fix tab size and addTabButton position with a KMessageWidget

[Yoann Laissus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102651/
-----------------------------------------------------------

(Updated Sept. 19, 2011, 8:56 p.m.)


Review request for rekonq.


Changes
-------

Yes, you're right. It's really better without this magic number :)

For TabBar::tabSizeHint(), I have only 20-30 calls for the 1st tab . I'll investigate that more tomorow, but I'm quite sure it's not rekonq related.


Summary
-------

When a KMessageWidget appears, the sizeHint width of the MainView grows up a lot. 
So it produces bigger tabs with an incorrect position of the addTabButton. (eg: Try to log in to Gmail)

I fixed this issue by setting a fixed max value for tab width. (MainView default width without a KMessageWidget)
I haven't found a cleaner way to do that.
I also removed a check which broke the addTabButton position in MainView.

Branch : git://anongit.kde.org/clones/rekonq/laissus/rekonq-clone.git fixTabSize


Diffs (updated)
-----

  src/mainview.h ce17a77 
  src/mainview.cpp 716e8da 
  src/tabbar.cpp 2c28573 

Diff: http://git.reviewboard.kde.org/r/102651/diff


Testing
-------


Thanks,

Yoann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110919/e8d24b92/attachment.html>