[rekonq] Review Request: Fix tab size and addTabButton position with a KMessageWidget

[Andrea Diamantini]

> On Sept. 18, 2011, 9:44 p.m., Andrea Diamantini wrote:
> > src/tabbar.h, line 67
> > <http://git.reviewboard.kde.org/r/102651/diff/1/?file=36346#file36346line67>
> >
> >     uhm... why this "magic number"? Cannot we desume it by calling mainview.sizeHint() just once?

I noticed another interesting thing testing your code. To load rekonq with ONE tab, we call 82 times the TabBar::tabSizeHint() method. They become 230 just loading the second tab. So, I'm asking: cannot we get rid/limit/enlight it??


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102651/#review6627
-----------------------------------------------------------


On Sept. 17, 2011, 8:27 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102651/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2011, 8:27 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> When a KMessageWidget appears, the sizeHint width of the MainView grows up a lot. 
> So it produces bigger tabs with an incorrect position of the addTabButton. (eg: Try to log in to Gmail)
> 
> I fixed this issue by setting a fixed max value for tab width. (MainView default width without a KMessageWidget)
> I haven't found a cleaner way to do that.
> I also removed a check which broke the addTabButton position in MainView.
> 
> Branch : git://anongit.kde.org/clones/rekonq/laissus/rekonq-clone.git fixTabSize
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp 716e8da 
>   src/tabbar.h 1949673 
>   src/tabbar.cpp 2c28573 
> 
> Diff: http://git.reviewboard.kde.org/r/102651/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110918/e2600ac9/attachment.html>