<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102651/">http://git.reviewboard.kde.org/r/102651/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2011, 8:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, you're right. It's really better without this magic number :)
For TabBar::tabSizeHint(), I have only 20-30 calls for the 1st tab . I'll investigate that more tomorow, but I'm quite sure it's not rekonq related.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a KMessageWidget appears, the sizeHint width of the MainView grows up a lot.
So it produces bigger tabs with an incorrect position of the addTabButton. (eg: Try to log in to Gmail)
I fixed this issue by setting a fixed max value for tab width. (MainView default width without a KMessageWidget)
I haven't found a cleaner way to do that.
I also removed a check which broke the addTabButton position in MainView.
Branch : git://anongit.kde.org/clones/rekonq/laissus/rekonq-clone.git fixTabSize</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainview.h <span style="color: grey">(ce17a77)</span></li>
<li>src/mainview.cpp <span style="color: grey">(716e8da)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(2c28573)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102651/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>