[rekonq] Re: Review Request: Port rekonq to the new KMessageWidget

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101814/#review4406
-----------------------------------------------------------


Just a few quick comments from running it:

- there's no way to discard the favorite (for setting a new favorite in about:favorites) bar.
- animating the viewport's resize might have a cost. maybe we should put the widget in overlay for the animation and only insert it in the layout at the end of the animation.
- the highlight (blink) is not there anymore, but that's probably something we can live with, since KMessageWidget is not easy to miss !

I'll try to do a proper review later on.


- Pierre


On July 2, 2011, 12:59 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101814/
> -----------------------------------------------------------
> 
> (Updated July 2, 2011, 12:59 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Move to KMessageWidget
>     
> Port rekonq notification bars to KMessageWidget:
> walletbar, crash notification bar, set favorite preview bar.
> Remove old no more used notification bar
> 
> Code is available also on rekonq repo in a branch named "MovingToKMessageWidget".
> 
> About KMessageWidget: https://git.reviewboard.kde.org/r/101249/diff/1/ AND http://community.kde.org/Sprints/UX2011/KMessageWidget
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt db9506a 
>   src/application.cpp c00f3f9 
>   src/messagebar.h 6531366 
>   src/messagebar.cpp b5959d5 
>   src/notificationbar.h 49fc8e8 
>   src/notificationbar.cpp e7ee77d 
>   src/previewselectorbar.h 396f763 
>   src/previewselectorbar.cpp 16f4a9c 
>   src/walletbar.h 8c85c44 
>   src/walletbar.cpp cc08400 
>   src/websnap.h ab30c55 
>   src/webtab.h 092d6ce 
>   src/webtab.cpp 0994017 
> 
> Diff: http://git.reviewboard.kde.org/r/101814/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110705/cab9e930/attachment.htm