<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101814/">http://git.reviewboard.kde.org/r/101814/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just a few quick comments from running it:
- there's no way to discard the favorite (for setting a new favorite in about:favorites) bar.
- animating the viewport's resize might have a cost. maybe we should put the widget in overlay for the animation and only insert it in the layout at the end of the animation.
- the highlight (blink) is not there anymore, but that's probably something we can live with, since KMessageWidget is not easy to miss !
I'll try to do a proper review later on.
</pre>
<br />
<p>- Pierre</p>
<br />
<p>On July 2nd, 2011, 12:59 p.m., Andrea Diamantini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Andrea Diamantini.</div>
<p style="color: grey;"><i>Updated July 2, 2011, 12:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move to KMessageWidget
Port rekonq notification bars to KMessageWidget:
walletbar, crash notification bar, set favorite preview bar.
Remove old no more used notification bar
Code is available also on rekonq repo in a branch named "MovingToKMessageWidget".
About KMessageWidget: https://git.reviewboard.kde.org/r/101249/diff/1/ AND http://community.kde.org/Sprints/UX2011/KMessageWidget</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(db9506a)</span></li>
<li>src/application.cpp <span style="color: grey">(c00f3f9)</span></li>
<li>src/messagebar.h <span style="color: grey">(6531366)</span></li>
<li>src/messagebar.cpp <span style="color: grey">(b5959d5)</span></li>
<li>src/notificationbar.h <span style="color: grey">(49fc8e8)</span></li>
<li>src/notificationbar.cpp <span style="color: grey">(e7ee77d)</span></li>
<li>src/previewselectorbar.h <span style="color: grey">(396f763)</span></li>
<li>src/previewselectorbar.cpp <span style="color: grey">(16f4a9c)</span></li>
<li>src/walletbar.h <span style="color: grey">(8c85c44)</span></li>
<li>src/walletbar.cpp <span style="color: grey">(cc08400)</span></li>
<li>src/websnap.h <span style="color: grey">(ab30c55)</span></li>
<li>src/webtab.h <span style="color: grey">(092d6ce)</span></li>
<li>src/webtab.cpp <span style="color: grey">(0994017)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101814/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>