[rekonq] Re: Review Request: Port rekonq to the new KMessageWidget

Andrea Diamantini adjam7 at gmail.com
Sat Jul 2 14:59:15 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101814/
-----------------------------------------------------------

(Updated July 2, 2011, 12:59 p.m.)


Review request for rekonq.


Changes
-------

Insert back notification bars in webtab layout
    
As Pierre pointed out, better insert bars inside layout to avoid
usability loss.


Summary
-------

Move to KMessageWidget
    
Port rekonq notification bars to KMessageWidget:
walletbar, crash notification bar, set favorite preview bar.
Remove old no more used notification bar

Code is available also on rekonq repo in a branch named "MovingToKMessageWidget".

About KMessageWidget: https://git.reviewboard.kde.org/r/101249/diff/1/ AND http://community.kde.org/Sprints/UX2011/KMessageWidget


Diffs (updated)
-----

  src/CMakeLists.txt db9506a 
  src/application.cpp c00f3f9 
  src/messagebar.h 6531366 
  src/messagebar.cpp b5959d5 
  src/notificationbar.h 49fc8e8 
  src/notificationbar.cpp e7ee77d 
  src/previewselectorbar.h 396f763 
  src/previewselectorbar.cpp 16f4a9c 
  src/walletbar.h 8c85c44 
  src/walletbar.cpp cc08400 
  src/websnap.h ab30c55 
  src/webtab.h 092d6ce 
  src/webtab.cpp 0994017 

Diff: http://git.reviewboard.kde.org/r/101814/diff


Testing
-------


Thanks,

Andrea

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110702/a65e2a0a/attachment.htm 


More information about the rekonq mailing list