[rekonq] Review Request: option to open links from external applications in new window

[Thomas Zander]

> On Aug. 18, 2011, 10:57 p.m., Andrea Diamantini wrote:
> > I don't like this change.
> > First, I couldn't find a similar option in Firefox or Chromium: they continued opening external links in new tabs. The only way to change it (just on Firefox) is to change exactly the same settings rekonq has. It seems impossible to provide this behavior on Chromium.
> > Second, I usually open a lot of links from external tabs (eg: akregator, kmail). Why should I find them in different windows?
> >

Jumping in as this is a very similar subject to the other one I was talking about on the rekonq mailinglist;

people use virtual desktops and activities to separate out their work into discrete sections.
Consider this usecase;  (not uncommon!)
A personal activity runs kmail while at work, a work activity runs rekonq with gmail for work emails.
The user clicks on a link in kmail to show a webpage that is clearly for his personal activity;  maybe a facebook link...

Current behavior is that on his work activity, on another virtual desktop, a tab is added next to his work gmail tab.

With this patch (if I understand correctly) the click in kmail, on his personal activity, opens a window in that same activity and on the same virtual desktop.   Which is much more predictable and in line with the concepts that both virtual desktops and activities promote.
ps. did you know you can suspend an activity and that quits all windows there?  They save session and restarting the activity will restore that session.  Consider this with the above suggested behavior.

Bottom line; if I understand this patch correctly, I like it!


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102330/#review5806
-----------------------------------------------------------


On Aug. 15, 2011, 3:30 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102330/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2011, 3:30 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> patch by Pali Rohár.
> https://bugs.kde.org/show_bug.cgi?id=275477
> 
> 
> Diffs
> -----
> 
>   src/application.cpp a62d548 
>   src/rekonq.kcfg 4050c4a 
>   src/settings/settings_tabs.ui eb775d5 
> 
> Diff: http://git.reviewboard.kde.org/r/102330/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110819/9db6cc6a/attachment.html>