<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102330/">http://git.reviewboard.kde.org/r/102330/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 18th, 2011, 10:57 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't like this change.
First, I couldn't find a similar option in Firefox or Chromium: they continued opening external links in new tabs. The only way to change it (just on Firefox) is to change exactly the same settings rekonq has. It seems impossible to provide this behavior on Chromium.
Second, I usually open a lot of links from external tabs (eg: akregator, kmail). Why should I find them in different windows?
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jumping in as this is a very similar subject to the other one I was talking about on the rekonq mailinglist;
people use virtual desktops and activities to separate out their work into discrete sections.
Consider this usecase; (not uncommon!)
A personal activity runs kmail while at work, a work activity runs rekonq with gmail for work emails.
The user clicks on a link in kmail to show a webpage that is clearly for his personal activity; maybe a facebook link...
Current behavior is that on his work activity, on another virtual desktop, a tab is added next to his work gmail tab.
With this patch (if I understand correctly) the click in kmail, on his personal activity, opens a window in that same activity and on the same virtual desktop. Which is much more predictable and in line with the concepts that both virtual desktops and activities promote.
ps. did you know you can suspend an activity and that quits all windows there? They save session and restarting the activity will restore that session. Consider this with the above suggested behavior.
Bottom line; if I understand this patch correctly, I like it!</pre>
<br />
<p>- Thomas</p>
<br />
<p>On August 15th, 2011, 3:30 p.m., Johannes Tröscher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Johannes Tröscher.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2011, 3:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">patch by Pali Rohár.
https://bugs.kde.org/show_bug.cgi?id=275477</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(a62d548)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(4050c4a)</span></li>
<li>src/settings/settings_tabs.ui <span style="color: grey">(eb775d5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102330/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>