[rekonq] Review Request: option to open links from external applications in new window

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102330/#review5806
-----------------------------------------------------------


I don't like this change.
First, I couldn't find a similar option in Firefox or Chromium: they continued opening external links in new tabs. The only way to change it (just on Firefox) is to change exactly the same settings rekonq has. It seems impossible to provide this behavior on Chromium.
Second, I usually open a lot of links from external tabs (eg: akregator, kmail). Why should I find them in different windows?


- Andrea


On Aug. 15, 2011, 3:30 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102330/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2011, 3:30 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> patch by Pali Rohár.
> https://bugs.kde.org/show_bug.cgi?id=275477
> 
> 
> Diffs
> -----
> 
>   src/application.cpp a62d548 
>   src/rekonq.kcfg 4050c4a 
>   src/settings/settings_tabs.ui eb775d5 
> 
> Diff: http://git.reviewboard.kde.org/r/102330/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110818/8cc26084/attachment.html>