[rekonq] Review Request: fix Vi-like navigation shortcuts

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102255/#review5533
-----------------------------------------------------------


I was already not a big fan of this change the first time. Now even though the implementation is better, I still think this is gonna be a pain, e.g. for people wanting to use the shortcuts in GMail or friends. (I actually heard some complaints after the first implementation made it in...)
If we really want this, I think it *has* to be an opt-in thing.

- Pierre


On Aug. 8, 2011, 3:19 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102255/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2011, 3:19 p.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Summary
> -------
> 
> this feature got reverted by adjam with revision a47bb905 because there was no check if a widget stole the focus before (input or textarea).
> this sometimes corrupted your input. (i could reproduce it here on reviewboard)
> this patch fixes that feature by adding a check on the name of the active element's tag.
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp d832554 
> 
> Diff: http://git.reviewboard.kde.org/r/102255/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110809/d7e35e61/attachment.html>