<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102255/">http://git.reviewboard.kde.org/r/102255/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was already not a big fan of this change the first time. Now even though the implementation is better, I still think this is gonna be a pain, e.g. for people wanting to use the shortcuts in GMail or friends. (I actually heard some complaints after the first implementation made it in...)
If we really want this, I think it *has* to be an opt-in thing.</pre>
<br />
<p>- Pierre</p>
<br />
<p>On August 8th, 2011, 3:19 p.m., Johannes Tröscher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Andrea Diamantini.</div>
<div>By Johannes Tröscher.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2011, 3:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this feature got reverted by adjam with revision a47bb905 because there was no check if a widget stole the focus before (input or textarea).
this sometimes corrupted your input. (i could reproduce it here on reviewboard)
this patch fixes that feature by adding a check on the name of the active element's tag.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/webview.cpp <span style="color: grey">(d832554)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102255/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>