[rekonq] Review Request: fix Vi-like navigation shortcuts

Johannes Tröscher fritz_van_tom at hotmail.com
Tue Aug 9 10:53:47 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102255/
-----------------------------------------------------------

(Updated Aug. 9, 2011, 10:53 a.m.)


Review request for rekonq and Andrea Diamantini.


Changes
-------

made this feature optional, like pierre suggested. the check on the keys is now implemented using a switch for better readability.


Summary
-------

this feature got reverted by adjam with revision a47bb905 because there was no check if a widget stole the focus before (input or textarea).
this sometimes corrupted your input. (i could reproduce it here on reviewboard)
this patch fixes that feature by adding a check on the name of the active element's tag.


Diffs (updated)
-----

  src/rekonq.kcfg 4050c4a 
  src/settings/settings_general.ui d0c3165 
  src/webview.cpp d832554 

Diff: http://git.reviewboard.kde.org/r/102255/diff


Testing
-------

compiles and works


Thanks,

Johannes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110809/76c49a45/attachment.html>


More information about the rekonq mailing list