[rekonq] Re: Review Request: Fix icon duplication

[Jon Ander Peñalba]

> On 2010-10-18 11:53:37, Benjamin Poulain wrote:
> > src/urlbar/urlbar.cpp, lines 372-373
> > <http://git.reviewboard.kde.org/r/100067/diff/1/?file=998#file998line372>
> >
> >     I am not a fan of this condition.
> >     I would edit WebTab to have a method isPageLoading() returning a boolean. The condition could then be rewritten as 
> >     if (!_tab->isPageLoading()) {
> >     
> >     If not the above method, I would at least add a comment. Progress == 0 is too cryptic in my opinion.

I like the idea of an isPageLoading() method :)


- Jon Ander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100067/#review115
-----------------------------------------------------------


On 2010-10-17 17:55:24, Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100067/
> -----------------------------------------------------------
> 
> (Updated 2010-10-17 17:55:24)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Fix icon duplication in the urlbar if a bookmark is added during a page loading
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp 4039e8b 
> 
> Diff: http://git.reviewboard.kde.org/r/100067/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101018/83cbdc42/attachment.htm