[rekonq] Re: Review Request: Fix icon duplication

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100067/#review125
-----------------------------------------------------------

Ship it!


I approve the fix. And I like this improvement in WebTab API. Please, commit and backport to 0.6 branch. If you need help on, just ask :)

- Andrea


On 2010-10-18 17:09:21, Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100067/
> -----------------------------------------------------------
> 
> (Updated 2010-10-18 17:09:21)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Fix icon duplication in the urlbar if a bookmark is added during a page loading
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp d263111 
>   src/tabbar.cpp 1756c20 
>   src/urlbar/urlbar.cpp 4039e8b 
>   src/webtab.h 66eec44 
>   src/webtab.cpp 3b97e2d 
> 
> Diff: http://git.reviewboard.kde.org/r/100067/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101018/3fad4ba3/attachment-0001.htm