[rekonq] Re: Review Request: GCI Task: Saving zoom settings for each web site

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100207/#review572
-----------------------------------------------------------


I really cannot understand all these changes here to add this feature. In my mind, you need just to:
1) save zoom settings every time someone changes it (--> add it to the "change zoom settings" slot)
2) load (eventually) zoom settings on loadStarted/loadFinished.
No strange webview pointers in mainwindows nor methods in the application class, please. 

- Andrea


On 2010-12-12 19:00:10, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100207/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 19:00:10)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Save zoom settings for each web site
> 
> 
> Diffs
> -----
> 
>   src/application.h b30e337 
>   src/application.cpp 95aa9cf 
>   src/mainwindow.h 33fd202 
>   src/mainwindow.cpp c9863f0 
>   src/webview.h 9518b74 
>   src/webview.cpp e90b8da 
>   src/zoombar.cpp a895466 
> 
> Diff: http://git.reviewboard.kde.org/r/100207/diff
> 
> 
> Testing
> -------
> 
> Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101219/8458d880/attachment.htm