[rekonq] Re: Review Request: GCI Task: Saving zoom settings for each web site

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100207/#review509
-----------------------------------------------------------


I think the WebView class shouldn't have a single change for this feature. Plugging the functionality onto the signals it emits should be enough.


src/webview.cpp
<http://git.reviewboard.kde.org/r/100207/#comment400>

    how about using loadStarted() / loadFinished() instead ? For a page that's slow to load, this signal could be fired up to 100 times, you don't really want to update some settings (and hence potentially write to a file) that often.
    
    See:
    http://doc.qt.nokia.com/4.7/qwebview.html#loadProgress



src/webview.cpp
<http://git.reviewboard.kde.org/r/100207/#comment399>

    This call here seems wrong to me. IMO it should only be called from one place when the zoom factor is changed and different from the default value.


- Pierre


On 2010-12-12 19:00:10, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100207/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 19:00:10)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Save zoom settings for each web site
> 
> 
> Diffs
> -----
> 
>   src/application.h b30e337 
>   src/application.cpp 95aa9cf 
>   src/mainwindow.h 33fd202 
>   src/mainwindow.cpp c9863f0 
>   src/webview.h 9518b74 
>   src/webview.cpp e90b8da 
>   src/zoombar.cpp a895466 
> 
> Diff: http://git.reviewboard.kde.org/r/100207/diff
> 
> 
> Testing
> -------
> 
> Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101212/6c71e3d2/attachment.htm