[rekonq] Re: Google Code-In: First submission

[Panagiotis Papadopoulos]

Am Dienstag 07 Dezember 2010, 23:15:39 schrieb Pierre Rossi:
> Hi everybody,
> 
> Looks like a nice addition.
> I wonder why the i18nc call is necessary, but I trust you pano to have a
> good reason for that.

FWIW:

In some languages (e.g. German) the translation needs to add a space between the value and the % sign. By adding an i18n call this can be 
achieved :-) The comment is just a nice addition that shouldn’t hurt anyone ;-)

> The only little remark I would have about the patch is with the member
> QLabel naming ("percentage") it doesn't follow the member naming convention
> it'd seem (it stands out in the patch, all other members are prefixed with
> "m_").
> Other than that it's fine by me.

> Cheers,
> --
> Pierre