[rekonq] Re: Google Code-In: First submission

[Andrea Diamantini]

On Tuesday 07 December 2010 19:35:19 Panagiotis Papadopoulos wrote:
> Hello,
> 
> Our Student at Google Code-In, Furkan, already completed this task:
> http://www.google-melange.com/gci/task/show/google/gci2010/kde/t12915798455
> 7
> 
> It adds the current zoom percentage of the website to the zoombar.
> I attached his patch (which can also be found in the link above).
> 
> To me code looks good, and (pretty important:) it also works, I’d just need
> the OK of one of you, so that I can approve his work :-)
> 
> Greetings

The patch looks good and works well. I see just 2 issues on:
1) Are we sure that is the right position for the percentage? Mine is just a 
question, I have no real opinion on and if you think it is, feel free to 
ignore this.
2) the "percentage" member variable has to be called "m_percentage". The patch 
needs fixes accordingly.

Fixed this, you can merge it on.

Regards,

adjam, 
announcing he will finally have again time to work on rekonq during Christmas 
Holidays.

-- 
Andrea Diamantini, adjam
GPG Fingerprint: 57DE 8E32 7D1A 0E16 AA52 59D8 84F9 3ECD DBF9 730F

rekonq project
WEB: http://rekonq.sourceforge.net
IRC: rekonq at freenode
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101208/ee8f07ad/attachment.htm