[rekonq] Re: Google Code-In: First submission

[Pierre Rossi]

Hi everybody,

Looks like a nice addition.
I wonder why the i18nc call is necessary, but I trust you pano to have a
good reason for that.
The only little remark I would have about the patch is with the member
QLabel naming ("percentage") it doesn't follow the member naming convention
it'd seem (it stands out in the patch, all other members are prefixed with
"m_").
Other than that it's fine by me.

Cheers,
--
Pierre

On Tue, Dec 7, 2010 at 19:35, Panagiotis Papadopoulos <pano_90 at gmx.net>wrote:

> Hello,
>
> Our Student at Google Code-In, Furkan, already completed this task:
>
> http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129157984557
>
> It adds the current zoom percentage of the website to the zoombar.
> I attached his patch (which can also be found in the link above).
>
> To me code looks good, and (pretty important:) it also works, I’d just need
> the OK of one of you, so that I can approve his work :-)
>
> Greetings
> _______________________________________________
> rekonq mailing list
> rekonq at kde.org
> https://mail.kde.org/mailman/listinfo/rekonq
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101207/f2dd4f0c/attachment.htm