D29807: WIP: Change Chrome API design

Alexander Lohnau noreply at phabricator.kde.org
Sun May 17 17:14:19 BST 2020


alex created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  - The FindProfile class was only for Chrome implemented => removed
  - Having ProfileBookmarks and Profile class is unnecessary, especially because they are only needed for Chrome
  - Better error handling
  
  TODO: Adjust tests for chrome
  Have a second look at the changes ;-)

TEST PLAN
  Should work as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200517/a54addb0/attachment.htm>


More information about the Plasma-devel mailing list