D29807: WIP: Change Chrome API design

[Anthony Fieroni]

anthonyfieroni added reviewers: broulik, Plasma.
anthonyfieroni added a comment.


  Commented code should be removed.

INLINE COMMENTS

> chromeprofile.h:11
> +public:
> +    ProfileBookmarks(const QString &path, const QString &name);
> +    static QList<ProfileBookmarks *> findAllProfiles(const QString &applicationName);

You can move contructor to private section, that will make all things clear, `findAllProfiles` should be the only one allowed creator.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29807

To: alex, broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200517/1f022613/attachment.htm>