<table><tr><td style="">alex created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />alex requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29807">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">The FindProfile class was only for Chrome implemented => removed</li>
<li class="remarkup-list-item">Having ProfileBookmarks and Profile class is unnecessary, especially because they are only needed for Chrome</li>
<li class="remarkup-list-item">Better error handling</li>
</ul>

<p>TODO: Adjust tests for chrome<br />
Have a second look at the changes ;-)</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Should work as before</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>api_inconsistencies (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29807">https://phabricator.kde.org/D29807</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>runners/bookmarks/CMakeLists.txt<br />
runners/bookmarks/browserfactory.cpp<br />
runners/bookmarks/browsers/chrome.cpp<br />
runners/bookmarks/browsers/chrome.h<br />
runners/bookmarks/browsers/chromefindprofile.cpp<br />
runners/bookmarks/browsers/chromefindprofile.h<br />
runners/bookmarks/browsers/chromeprofile.cpp<br />
runners/bookmarks/browsers/chromeprofile.h<br />
runners/bookmarks/browsers/findprofile.h<br />
runners/bookmarks/faviconfromblob.cpp<br />
runners/bookmarks/faviconfromblob.h<br />
runners/bookmarks/fetchsqlite.cpp<br />
runners/bookmarks/fetchsqlite.h<br />
runners/bookmarks/tests/testchromebookmarks.cpp<br />
runners/bookmarks/tests/testchromebookmarks.h</div></div></div><br /><div><strong>To: </strong>alex<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>