D28172: [applets/digital-clock] Fix date sizing in vertical panel
Nathaniel Graham
noreply at phabricator.kde.org
Fri Mar 20 22:44:20 GMT 2020
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch fixes several errors in the code:
- The property is named `font.minimumPixelSize`, not `minimumPixelSize`
- The calculation in `minimumPixelSize` did not make sense
- Setting the height to `dateLabel.paintedHeight` is nonsensical
BUG: 417852
FIXED-IN: 5.18.4
TEST PLAN
F8186873: vokoscreenNG-2020-03-20_16-38-57.webm <https://phabricator.kde.org/F8186873>
REPOSITORY
R120 Plasma Workspace
BRANCH
fix-vertical-panel-date-text-sizing (branched from Plasma/5.18)
REVISION DETAIL
https://phabricator.kde.org/D28172
AFFECTED FILES
applets/digital-clock/package/contents/ui/DigitalClock.qml
To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200320/c0b7b961/attachment.html>
More information about the Plasma-devel
mailing list