D28167: Let Discover take the frequency of automatic update checks from apt.

Eli Acherkan noreply at phabricator.kde.org
Fri Mar 20 18:20:45 GMT 2020


eliac created this revision.
eliac added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
eliac requested review of this revision.

REVISION SUMMARY
  BUG: 419055
  
  Currently `PackageKitNotifier` attempts to check the frequency by running `apt-config dump` and looking for the `Apt::Periodic::Update-Package-Lists` property in its output. However, on my system the property name starts with uppercase `APT` rather than `Apt`, and ends with a semicolon.
  
  This patch is a defensive, backward-compatible fix. It assumes that under some circumstances the previous code was correct to look for `Apt` and no ending semicolon. To cover both cases, I edited the regexp to allow for an optional semicolon, and to make the comparison case-insensitive.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28167

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp

To: eliac
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, semareit, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ixoos, ZrenBot, James, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200320/d44bdc37/attachment.html>


More information about the Plasma-devel mailing list