<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: VDG, Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28172">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This patch fixes several errors in the code:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The property is named <tt style="background: #ebebeb; font-size: 13px;">font.minimumPixelSize</tt>, not <tt style="background: #ebebeb; font-size: 13px;">minimumPixelSize</tt></li>
<li class="remarkup-list-item">The calculation in <tt style="background: #ebebeb; font-size: 13px;">minimumPixelSize</tt> did not make sense</li>
<li class="remarkup-list-item">Setting the height to <tt style="background: #ebebeb; font-size: 13px;">dateLabel.paintedHeight</tt> is nonsensical</li>
</ul>
<p>BUG: 417852<br />
FIXED-IN: 5.18.4</p></div></div><br /><div><strong>TEST PLAN</strong><div><p><a href="https://phabricator.kde.org/F8186873" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8186873: vokoscreenNG-2020-03-20_16-38-57.webm</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-vertical-panel-date-text-sizing (branched from Plasma/5.18)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28172">https://phabricator.kde.org/D28172</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/digital-clock/package/contents/ui/DigitalClock.qml</div></div></div><br /><div><strong>To: </strong>ngraham, VDG, Plasma<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>