D26912: Use Qt5 signal syntax, format files, optimizations

[Alexander Lohnau]

alex added a comment.


  Yes, I have used an automatic formatter.
  
  And in general about formatting: When I commit a patch which contains code changes, should I format the files (even the code that I don't directly edit) or would it be easier for the reviewers if I commit this in a separate patch ?
  Or should I not reformat the files, to not stress the reviewers/maintainers ?
  
  And what would be a good place to ask about the code of a project or discuss some ideas (on both Phabricator and Gitlab).
  
  Thank you very much :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200130/ab3f9095/attachment-0001.html>