D22005: Ensure url from KActivity resources are properly built

Méven Car noreply at phabricator.kde.org
Sat Jan 25 14:40:39 GMT 2020


meven abandoned this revision.
meven added a comment.


  After further check, my patch does not do much, just allowed me to discover bug about dolphin's recent folder list missing.
  
    if (QDir::isAbsolutePath(resource)) {
        resource = QUrl::fromLocalFile(resource).toString();
    }
  
  Here `QDir::isAbsolutePath` will always be true because at line 312 ` | Url::file();`  we requested files only.
  
  Same is true for D24728 <https://phabricator.kde.org/D24728>

INLINE COMMENTS

> backend.cpp:336
>  
>          if (!fileItem.isFile()) {
>              continue;

This prevents filemanager (or apps that opens dirs) to display their recent directories will fix.
Same goes in D24728 <https://phabricator.kde.org/D24728>.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22005

To: meven, #plasma, hein, broulik
Cc: ivan, meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200125/9e03c153/attachment.html>


More information about the Plasma-devel mailing list