D27701: [ComboBox] Use transparent dimmer

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Feb 27 14:26:38 GMT 2020


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When not using `dim` it breaks "click outside" for `ComboBox` when in a `ScrollView`.
  I believe because without an actual `Item` the `Popup` filters some events and might have them stolen by the `Flickable`?
  So we keep `dim` on but use a transparent `Item` to avoid it actually dimming its surroundings.

TEST PLAN
  - Kirigami gallery `ComboBox` still doesn't dim (it does without the `Item`)
  - `ComboBox` in QtQuick KCMs like KScreen KCM now close properly on click outside

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200227/969fa39a/attachment.html>


More information about the Plasma-devel mailing list