D27700: Change copy to binary to use a custom target that always runs

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Feb 27 14:22:15 GMT 2020


apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:86
>                              make_directory ${CMAKE_BINARY_DIR}/bin/org/kde/kirigami.2/)
> -    add_custom_command(TARGET kirigamiplugin POST_BUILD
> +    add_custom_command(TARGET copy_to_bin POST_BUILD
>                          COMMAND ${CMAKE_COMMAND} -E

Maybe pass different COMMAND to the same add_custom_command? As is it reads like you're declaring the command several times.

See https://cmake.org/cmake/help/v3.13/command/add_custom_command.html

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27700

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200227/a6faef0e/attachment-0001.html>


More information about the Plasma-devel mailing list