D27096: Refactoring, improve validation in kcm, optimize

[Alexander Lohnau]

alex added a comment.


  First of all thanks for the idea, but is the QString API needed  ? These strings are just used for reading the config and if you have a look at the implementation of the readEntry method:
  
    QStringList KConfigGroup::readEntry(const QString &key, const QStringList &aDefault) const
    {
         return readEntry(key.toUtf8().constData(), aDefault);
    }
  
  Basically the method is just converting the QString to a char array and calls the readEntry method (which is currently directly called).
  Link: https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/kconfig/html/kconfiggroup_8cpp_source.html#l00717

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27096

To: alex, davidedmundson, ngraham, sitter, broulik, #plasma
Cc: dvratil, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200224/8cdf5464/attachment.html>