D27096: Refactoring, improve validation in kcm, optimize

Daniel Vrátil noreply at phabricator.kde.org
Mon Feb 24 16:17:38 GMT 2020


dvratil added inline comments.

INLINE COMMENTS

> config_keys.h:23
>  
> -#include <KRunner/AbstractRunner>
> +static const char CONFIG_TRIGGERWORD[] = "triggerWord";
> +static const char CONFIG_ALIASES[] = "aliases";

You could use `static constexpr QStringView CONFIG_TRIGGERWORD = u"triggerWord"` to get something that's compile-time and easily used with QString API

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27096

To: alex, davidedmundson, ngraham, sitter, broulik, #plasma
Cc: dvratil, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200224/9377c628/attachment.html>


More information about the Plasma-devel mailing list