D27096: Refactoring, improve validation in kcm, optimize

Harald Sitter noreply at phabricator.kde.org
Tue Feb 25 10:08:50 GMT 2020


sitter added a subscriber: davidre.
sitter added a comment.


  Huh, guess kconfig never goes to QString after all.
  
  @davidre had a similar suggestion of using auto instead and let the compiler do its work IIRC
  
  dvratil's comment still applies to DEFAULT_TRIGGERWORD though.
  
  Generally speaking the global static keyword strings aren't very popluar in our code. Although, TBH, I do not know why.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27096

To: alex, davidedmundson, ngraham, sitter, broulik, #plasma
Cc: davidre, dvratil, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/268a19f9/attachment.html>


More information about the Plasma-devel mailing list