D27590: Calculate needsSave on checkbox toggle not on change

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Otherwise we will trigger it during load, which is wasteful.
  
  But worse potentially we haven't evaluated the other settings yet, so it
  could trigger that we have changed the settings, and prematurely set
  apply to enabled prematurely which currently breaks things.
  
  I suspect it will fix the bug below, I couldn't reproduce reliably
  enough to prove it.
  
  Please reopen if it remains an issue
  
  BUG: 411584
  Fixed-in: 5.18.2

TEST PLAN
  Opened KCM
  toggling still worked as expected

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27590

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200222/a818d83c/attachment.html>