<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />davidedmundson requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27590">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Otherwise we will trigger it during load, which is wasteful.</p>

<p>But worse potentially we haven't evaluated the other settings yet, so it<br />
could trigger that we have changed the settings, and prematurely set<br />
apply to enabled prematurely which currently breaks things.</p>

<p>I suspect it will fix the bug below, I couldn't reproduce reliably<br />
enough to prove it.</p>

<p>Please reopen if it remains an issue</p>

<p>BUG: 411584<br />
Fixed-in: 5.18.2</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Opened KCM<br />
toggling still worked as expected</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27590">https://phabricator.kde.org/D27590</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/nightcolor/package/contents/ui/main.qml</div></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>