D28627: WIP: Made panel opaque on maximized window

[Niccolò Venerandi]

niccolove added a comment.


  > You're rendering a transparent panel. we're still even blurring the background very expensively. And then we're drawing something on top. That's very wasteful.
  >  We're also mixing up shadows from one SVG with the output of another.
  
  Right. Originally I just changed the svg to be opaque, but I couldn't get a transition out of it. Also, I guess this doesn't solve the blurring problem.
  
  > Also our isMaximised detection is horrific.
  
  What do you mean with our? Is the way I used TaskManager very wrong (quite possible) or is the window.isMaximized implementation bad in win?
  
  > We also need to think about how this plays in with other themes. You can't assume everyone uses Breeze.
  
  I checked this. It always fallback to Breeze opaque background following the theme colors, so it should always work without breaking them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: niccolove, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200407/0bede627/attachment-0001.html>