D28627: WIP: Made panel opaque on maximized window

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.


  Ok, so the logic is - the goal is to blend in. If you're not showing the desktop, you can't blend in to it. I can at least understand the thought process.
  
  ---
  
  Code wise, this needs a lot of work.
  
  You're rendering a transparent panel. we're still even blurring the background very expensively. And then we're drawing something on top. That's very wasteful.
  We're also mixing up shadows from one SVG with the output of another.
  
  Also our isMaximised detection is horrific.
  
  -------
  
  We also need to think about how this plays in with other themes. You can't assume everyone uses Breeze.

INLINE COMMENTS

> Panel.qml:59
> +        onActiveTaskChanged: {
> +            visibleWindowsModel.sourceModel = tasksModel
> +        }

why

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: niccolove, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200407/c28b0d57/attachment.html>