<table><tr><td style="">niccolove added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28627">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>You're rendering a transparent panel. we're still even blurring the background very expensively. And then we're drawing something on top. That's very wasteful.<br />
We're also mixing up shadows from one SVG with the output of another.</p></blockquote>
<p>Right. Originally I just changed the svg to be opaque, but I couldn't get a transition out of it. Also, I guess this doesn't solve the blurring problem.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also our isMaximised detection is horrific.</p></blockquote>
<p>What do you mean with our? Is the way I used TaskManager very wrong (quite possible) or is the window.isMaximized implementation bad in win?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>We also need to think about how this plays in with other themes. You can't assume everyone uses Breeze.</p></blockquote>
<p>I checked this. It always fallback to Breeze opaque background following the theme colors, so it should always work without breaking them.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28627">https://phabricator.kde.org/D28627</a></div></div><br /><div><strong>To: </strong>niccolove, Plasma, davidedmundson<br /><strong>Cc: </strong>ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>