D24110: Enable removing multiple devices at once

[Nathaniel Graham]

ngraham added reviewers: VDG, Plasma.
ngraham added inline comments.

INLINE COMMENTS

> devices.cpp:235
> +    if (KMessageBox::questionYesNo(this, i18n("Are you sure that you want to remove %1 devices from the list of known devices?", indexes.size()),
> +                                   i18nc("Title of window that asks for confirmation when removing a device", "Device removal")) == KMessageBox::Yes) {
> +        for (QModelIndex index : indexes) {

Need to override the button titles so they say "Remove" and "Cancel". "Yes" and "No" are never acceptable dialog button text.

Also, are you sure this needs a confirmation dialog at all? These are usually seen by the user as very annoying. If you feel like there should be more safety here, consider adding an Undo feature instead, and exposing it with a KMessageWidget/Kirigami.InlineMessage with an Undo button that appears somewhere in the UI after the items are removed.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D24110

To: umanovskis, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190920/0f60d3c6/attachment.html>