<table><tr><td style="">ngraham added reviewers: VDG, Plasma.<br />ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24110">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24110#inline-136433">View Inline</a><span style="color: #4b4d51; font-weight: bold;">devices.cpp:235</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">questionYesNo</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Are you sure that you want to remove %1 devices from the list of known devices?"</span><span class="p">,</span> <span class="n">indexes</span><span class="p">.</span><span class="n">size</span><span class="p">()),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                   <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"Title of window that asks for confirmation when removing a device"</span><span class="p">,</span> <span style="color: #766510">"Device removal"</span><span class="p">))</span> <span style="color: #aa2211">==</span> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">Yes</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">QModelIndex</span> <span style="color: #a0a000">index</span> <span class="p">:</span> <span class="n">indexes</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Need to override the button titles so they say "Remove" and "Cancel". "Yes" and "No" are never acceptable dialog button text.</p>

<p style="padding: 0; margin: 8px;">Also, are you sure this needs a confirmation dialog at all? These are usually seen by the user as very annoying. If you feel like there should be more safety here, consider adding an Undo feature instead, and exposing it with a KMessageWidget/Kirigami.InlineMessage with an <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Undo</span></span></span> button that appears somewhere in the UI after the items are removed.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R97 Bluedevil</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24110">https://phabricator.kde.org/D24110</a></div></div><br /><div><strong>To: </strong>umanovskis, VDG, Plasma<br /><strong>Cc: </strong>ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>